isIpAddr to not Return True when Extra Characters Follow IP Address #2182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankiesz
requested review from
YPandas,
Copilot,
sirknightj and
unicornss
and removed request for
Copilot
Copilot finished reviewing on behalf of
stefankiesz
November 24, 2025 18:14
Ahhorse1
reviewed
Nov 25, 2025
|
|
||
| // Check if IPv6 address. | ||
| offset = 0; | ||
| if (sscanf(hostname, "%x:%x:%x:%x:%x:%x:%x:%x%n", &ip_1, &ip_2, &ip_3, &ip_4, &ip_5, &ip_6, &ip_7, &ip_8, &offset) == 8 && |
There was a problem hiding this comment.
Should we do checks here as similar to the <= 255 done for IPv4?
sirknightj
reviewed
Nov 27, 2025
| return status; | ||
|
|
||
| // Check if IPv4 address. | ||
| if (sscanf(hostname, "%u.%u.%u.%u%n", &ip_1, &ip_2, &ip_3, &ip_4, &offset) == 4 && ip_1 <= 255 && ip_2 <= 255 && ip_3 <= 255 && ip_4 <= 255 && |
Contributor
There was a problem hiding this comment.
Is the IPV4/IPV6 template still used?
Also suggest to use the macro version SSCANF and STRLEN
Contributor
|
Would like to see a new testcase added for the ?transport=udp mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
isIpAddrnow considers the length of the inputted string compared to the IP-format-matched string.Why was it changed?
isIpAddrfunction.How was it changed?
What testing was done for the changes?
isIpaddr), and resulted in a successful relayed WebRTC streaming session.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.