Clarify the signerName in the example as being the only valid signerName #1160
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had used this example, but it was not clear to me that the `beta.eks.amazonaws.com/app-serving` value for `signerName` was required in order for EKS to sign my certificates, and I had used my own custom signer name instead. This PR adds some suggestions for clarifying the required value of `signerName` to have EKS sign any certificates.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
I had used this example, but it was not clear to me that the
beta.eks.amazonaws.com/app-servingvalue forsignerNamewas required in order for EKS to sign my certificates, and I had used my own custom signer name instead. This PR adds some suggestions for clarifying the required value ofsignerNameto have EKS sign any certificates.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.