feat: add support for IpAddressType #3840
Open
+2,198
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We discussed offline. The PR looks good, but ideally this can include the changes required to support IpAddressType for custom Domain's EndpointConfiguration too and not only for the top level API. |
br0connor
commented
Nov 10, 2025
| current_region_does_not_support([REST_API]), | ||
| "Rest API is not supported in this testing region", | ||
| ) | ||
| class TestApiWithDomainIpAddressType(BaseInternalTest): |
Author
There was a problem hiding this comment.
As this kind of test uses internal domain / certificate's that are already created I was not able to run it.
br0connor
commented
Nov 10, 2025
| return ApiDomainResponse(domain, basepath_resource_list, record_set_group) | ||
|
|
||
| def _construct_api_domain_v2( | ||
| def _construct_api_domain_v2( # noqa: PLR0915 |
Author
There was a problem hiding this comment.
The three lines I added put this over the tipping point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
closes 3757
Description of changes
Enables us to set
AWS::ApiGateway::RestApiresource'sEndpointConfiguration.IpAddressTypewith SAM by adding that property to the template. I'm an AWS employee message me on slack for more details@tooconDescription of how you validated changes
pytest --no-cov integration/combination/test_*api*.pyChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.