fix: submodule config for files is erroneously loaded from directory #2407
+90
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a submodule is exported from a file in a directory, we look for
`.jsiirc.json` in the same directory.
That was only intended for exporting a `directory/index.ts` as
a submodule, and is wrong when submodules are exported from files
in the same directory. Consider:
```
- root.ts export * from './submodule';
- submodule
+-- index.ts export * from './subsubmodule';
+-- subsubmodule.ts
+-- .jsiirc.json // <-- gets used for both submodules!
```
Instead, only use the directory-level `.jsiirc.json` if the exported
file is `index.ts`. Otherwise, for submodules read the jsii config from
`subsubmodule.jsiirc.json`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a submodule is exported from a file in a directory, we look for
.jsiirc.jsonin the same directory.That was only intended for exporting a
directory/index.tsas a submodule, and is wrong when submodules are exported from files in the same directory. Consider:Instead, only use the directory-level
.jsiirc.jsonif the exported file isindex.ts. Otherwise, for submodules read the jsii config fromsubsubmodule.jsiirc.json.Also adds a validation for multiple submodules not accidentally sharing the same Python module name (or Go, or Java, ...)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.