Skip to content

Conversation

@alextwoods
Copy link
Contributor

Fix NPE when using AnonymousCredentials in a credential provider chain with S3 CRT client.

Motivation and Context

Fixes #5810

Modifications

Add an additional check that resolved credentials are from the AnonymousCredentialsProvider before trying to use accessKey/secretAccessKey.

Testing

New unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner November 7, 2025 17:03
@alextwoods alextwoods enabled auto-merge November 7, 2025 17:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

@alextwoods alextwoods added this pull request to the merge queue Nov 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2025
@alextwoods alextwoods added this pull request to the merge queue Nov 7, 2025
@alextwoods alextwoods removed this pull request from the merge queue due to a manual request Nov 7, 2025
@alextwoods alextwoods added this pull request to the merge queue Nov 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3CrtAsyncClient does not work with AnonymousCredentialsProvider

2 participants