feat(batch): add ECS_AL2023_NVIDIA #36161
Open
+1,210
−2,375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
beginning-contributor
aws-cdk-automation
previously requested changes
Nov 23, 2025
Sas-ry
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
|
@Sas-ry thanks for submitting the PR ;) hope the contribution team will give it a review soon |
XaaXaaX
reviewed
Nov 25, 2025
| this.instanceTypes = props.instanceTypes ?? []; | ||
| this.instanceClasses = props.instanceClasses ?? []; | ||
| if (this.images?.find(image => image.imageType === EcsMachineImageType.ECS_AL2023) && | ||
| if (this.images?.find(image => image.imageType === EcsMachineImageType.ECS_AL2023 || image.imageType === EcsMachineImageType.ECS_AL2023_NVIDIA) && |
There was a problem hiding this comment.
if( [ EcsMachineImageType.ECS_AL2023, EcsMachineImageType.ECS_AL2023_NVIDIA ].includes(image.imageType)) ...`
Author
There was a problem hiding this comment.
@XaaXaaX
Thanks for your review comment!
I think your suggestion is better than the current code, so I’ve applied it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
#35839
Reason for this change
As explained in #35839, Amazon Linux 2 will reach its end of life (EOL) at the end of June 2026. Therefore, we have added a new option, “ECS_AL2023_NVIDIA,” to enable the specification of Amazon Linux 2023.
Description of changes
This release adds support for ECS_AL2023_NVIDIA to AWS Batch Compute Environment, enabling the execution of GPU workloads on Amazon Linux 2023.
Describe any new or updated permissions being added
N/A - Supports ECS_AL2023_NVIDIA
Description of how you validated changes
Unit tests and integration tests have been updated, and it is now possible to verify that both pass.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license