Skip to content

removed the schema field from properties #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

removed the schema field from properties #3408

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3622f8
removed schema field
ekang7 Nov 8, 2025
b025020
made schema field skipped but kept backwards compatibility
ekang7 Nov 10, 2025
6872558
Merge remote-tracking branch 'origin/qv2' into deleteSchemaRefToQ
ekang7 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions crates/chat-cli/src/cli/agent/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,9 @@ pub enum AgentConfigError {
#[serde(rename_all = "camelCase", deny_unknown_fields)]
#[schemars(description = "An Agent is a declarative way of configuring a given instance of q chat.")]
pub struct Agent {
#[serde(rename = "$schema", default = "default_schema")]
pub schema: String,
#[serde(rename = "$schema", skip_serializing_if = "Option::is_none", default)]
#[schemars(skip)]
pub schema: Option<String>,
/// Name of the agent
pub name: String,
/// This field is not model facing and is mostly here for users to discern between agents
Expand Down Expand Up @@ -180,7 +181,7 @@ pub struct Agent {
impl Default for Agent {
fn default() -> Self {
Self {
schema: default_schema(),
schema: None,
name: DEFAULT_AGENT_NAME.to_string(),
description: Some("Default agent".to_string()),
prompt: Default::default(),
Expand Down Expand Up @@ -990,10 +991,6 @@ pub fn queue_permission_override_warning(
)?)
}

fn default_schema() -> String {
"https://raw.githubusercontent.com/aws/amazon-q-developer-cli/refs/heads/main/schemas/agent-v1.json".into()
}

// Check if a tool reference is MCP-specific (not @builtin and starts with @)
pub fn is_mcp_tool_ref(s: &str) -> bool {
// @builtin is not MCP, it's a reference to all built-in tools
Expand Down Expand Up @@ -1277,7 +1274,7 @@ mod tests {
allowed_tools.insert("@server3/tool_*".to_string());

let agent = Agent {
schema: "test".to_string(),
schema: None,
name: "test-agent".to_string(),
description: None,
prompt: None,
Expand Down
Loading