Fix: Non-Claude models cannot be used in AgentCore #1347
Merged
+60
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load SUPPORTED_CACHE_FIELDS from environment variable to maintain single source of truth in TypeScript (packages/common/model.ts). This follows the same pattern as MCP_SERVERS configuration: - CDK injects SUPPORTED_CACHE_FIELDS via environment variable - Python runtime reads from environment - Claude models: cache_prompt + cache_tools enabled - Nova models: cache_prompt only (no cache_tools) - Other models: no caching (safe default) Changes: - generic-agent-core.ts: Pass SUPPORTED_CACHE_FIELDS as env var - config.py: Load from env var with standard Python style - agent.py: Conditional BedrockModel initialization Fixes: ValidationException when using Nova models with AgentCore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Problem
AgentCore failed with
ValidationExceptionwhen using non-Claude models (e.g., Nova models). Only Claude models were working properly due to hardcoded prompt caching configuration.Error example:
Root Cause
The
config.pyhad hardcoded cache configuration that enabledcache_promptandcache_toolsfor all models, but Nova models only supportcache_prompt(notcache_tools).Solution
SUPPORTED_CACHE_FIELDSenvironment variablepackages/common/model.tsBedrockModelwith appropriate cache settings:cache_prompt=True, cache_tools=Truecache_prompt=True(no cache_tools)Checklist
npm run cdk:testand updated snapshots withnpm run cdk:test:update-snapshot