Generating regional STS endpoints to allow for default EBS encryption in opt-in regions #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so that we can build a regional STS endpoint.
IevIe
approved these changes
Feb 4, 2025
Contributor
IevIe
left a comment
IevIe
left a comment
There was a problem hiding this comment.
Reviewed. Passed all scanners. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… so that we can build a regional STS endpoint.
Fixes #222
Global STS Client endpoints will not work for new (opt-in) regions.
Updated the logic under the
ec2_default_ebs_encryptionto generate regional endpoints so that STS can properly apply default EBS encryption in opt-in regions.By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].
Apache 2.0 License