-
Notifications
You must be signed in to change notification settings - Fork 15
Add nightly dependency bump workflow #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add nightly dependency bump workflow #271
Conversation
This reverts commit 807dc85.
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - zhaez/nightly-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove after testing finalized
thpierce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed .github/workflows
| needs: [ build, application-signals-e2e-test ] | ||
| runs-on: ubuntu-latest | ||
| if: always() | ||
| if: always() && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if: always() && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/')) | |
| if: always() && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/v')) |
| push: | ||
| branches: | ||
| - zhaez/nightly-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
| - name: Check for breaking changes | ||
| id: breaking_changes | ||
| run: node scripts/find_breaking_changes.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no env?
| - name: Configure git and create branch | ||
| run: | | ||
| git config --local user.name "github-actions" | ||
| git config --local user.email "github-actions@github.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep consistent across lang.
| - name: Configure git and create branch | |
| run: | | |
| git config --local user.name "github-actions" | |
| git config --local user.email "github-actions@github.com" | |
| - name: Setup Git | |
| run: | | |
| git config user.name "github-actions" | |
| git config user.email "github-actions@github.com" |
| publish-nightly-build-status: | ||
| name: "Publish Nightly Build Status" | ||
| needs: [update-dependencies, build-and-test, create-pr] | ||
| runs-on: ubuntu-latest | ||
| if: always() | ||
| steps: | ||
| - name: Configure AWS Credentials for emitting metrics | ||
| uses: aws-actions/configure-aws-credentials@a03048d87541d1d9fcf2ecf528a4a65ba9bd7838 #v5.0.0 | ||
| with: | ||
| role-to-assume: ${{ secrets.MONITORING_ROLE_ARN }} | ||
| aws-region: ${{ env.AWS_DEFAULT_REGION}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| publish-nightly-build-status: | |
| name: "Publish Nightly Build Status" | |
| needs: [update-dependencies, build-and-test, create-pr] | |
| runs-on: ubuntu-latest | |
| if: always() | |
| steps: | |
| - name: Configure AWS Credentials for emitting metrics | |
| uses: aws-actions/configure-aws-credentials@a03048d87541d1d9fcf2ecf528a4a65ba9bd7838 #v5.0.0 | |
| with: | |
| role-to-assume: ${{ secrets.MONITORING_ROLE_ARN }} | |
| aws-region: ${{ env.AWS_DEFAULT_REGION}} | |
| publish-nightly-build-status: | |
| name: "Publish Nightly Build Status" | |
| needs: [ update-dependencies, build-and-test, create-pr ] | |
| runs-on: ubuntu-latest | |
| if: always() | |
| steps: | |
| - name: Configure AWS Credentials for emitting metrics | |
| uses: aws-actions/configure-aws-credentials@a03048d87541d1d9fcf2ecf528a4a65ba9bd7838 #5.0.0 | |
| with: | |
| role-to-assume: ${{ secrets.MONITORING_ROLE_ARN }} | |
| aws-region: ${{ env.AWS_DEFAULT_REGION }} |
| echo "has_changes=true" >> $GITHUB_OUTPUT | ||
| git add . | ||
| git commit -m "chore: update OpenTelemetry dependencies to latest versions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why latest versions?
| - name: Install dependencies | ||
| run: npm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
Issue #, if available:
Description of changes:
Add a workflow
nightly-build.ymlwith following actions:nightly-dependency-updatesbranchExample nightly build PR: #273
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.