Skip to content

Update how the date string is created in the tests #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update how the date string is created in the tests #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3070c14
Update how the date string is created in the tests
kddejong Aug 15, 2024
90001b1
Attempt to fix colima starting issues
kddejong Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
# Docker engine is no longer available because of licensing
# Alternative Colima is part of the github macOS runner
# SAM v1.47.0+ needed for colima support, unable to use Python 3.6
colima start
colima start --arch x86_64
# Ensure colima is configured for later user
echo "DOCKER_HOST=unix://$HOME/.colima/default/docker.sock" >> $GITHUB_ENV
# Verify Docker
Expand Down
8 changes: 4 additions & 4 deletions tests/lib/log-delivery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,11 +1271,11 @@ describe('when delivering logs', () => {
loggerProxy.addLogPublisher(s3Logger);

loggerProxy.log('count: [%d]', 5.12);
loggerProxy.log('timestamp: [%s]', new Date('2020-01-01'));
loggerProxy.log('timestamp: [%s]', new Date('2020-01-01').toISOString());

loggerProxy.log('timestamp: [%s]', new Date('2020-01-02'));
loggerProxy.log('timestamp: [%s]', new Date('2020-01-03'));
loggerProxy.log('timestamp: [%s]', new Date('2020-01-04'));
loggerProxy.log('timestamp: [%s]', new Date('2020-01-02').toISOString());
loggerProxy.log('timestamp: [%s]', new Date('2020-01-03').toISOString());
loggerProxy.log('timestamp: [%s]', new Date('2020-01-04').toISOString());
expect(inspect.defaultOptions.depth).toBe(8);
await loggerProxy.waitCompletion();

Expand Down