feat(gen2-migration): implement provider-specific OAuth scopes for auth migration #14373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract provider-specific scopes from Identity Provider details - Add support for googleScopes, facebookScopes, amazonScopes, appleScopes - Map Facebook's public_profile to Cognito's profile scope - Update codegen to embed scopes in individual provider configurations - Remove global scopes from externalProviders configuration - Add comprehensive test coverage for provider-specific scope extraction Fixes issue where all OAuth providers shared the same global scopes, losing provider-specific configurations during Gen 1 to Gen 2 migration.
dgandhi62
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Issue
The migration tool incorrectly applies global OAuth scopes to all social login providers, losing provider-specific scope configurations that existed in Gen 1.
Example:
openid email profile scopespublic_profilescope['email', 'openid', 'phone', 'profile']to both providersSolved
Implemented provider-specific OAuth scope extraction and generation to preserve original Gen 1 configurations.
Note
I also added documentation to the auth adapter file with this pr