fix: separate environmentVariables and secrets condition checks to avoid unintended nesting #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fix #347, and similar comment #334 (comment)
This pull request separates the condition checks for
environmentVariablesandsecrets.Previously, the
secretscheck was nested inside theenvironmentVariablescondition, which could lead to unintended dependencies or confusion in the logic.Description of changes:
secretscondition check outside of theenvironmentVariablesblock.Note
Previous Pull Request #334 that introduced secrets, there was a mention of "backward compatibility".
Does this refer to secrets being nested under environmentVariables?
If so, this change modifies that behavior and needs further consideration.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.