Rust 1.89 baseline #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.89.0 is when AVX-512 support was stabilized. Moving to 1.89.0 allows us to remove a lot of legacy code gated behind the `rustversion` crate, simplifying things and improving maintainability.
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the minimum supported Rust version from 1.81 to 1.89 to enable unconditional use of AVX-512 intrinsics. The change removes all conditional compilation based on Rust version, simplifying the codebase significantly.
- Removes the
rustversiondependency and all#[rustversion::since(1.89)]and#[rustversion::before(1.89)]attributes - Eliminates runtime and compile-time checks for Rust version support of AVX-512 features
- Updates CI workflows to test only Rust 1.89+ versions
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumps rust-version to 1.89, removes rustversion and indexmap dependencies |
| Cargo.lock | Updates lockfile version to 4 and indexmap version to 2.12.0, removes rustversion |
| src/feature_detection.rs | Removes rust_version_supports_avx512 field and related version checking logic, removes duplicate version-gated enums and functions |
| src/crc32/fusion/x86/mod.rs | Removes rustversion attributes and pre-1.89 fallback implementations |
| src/crc32/fusion/x86/iscsi/*.rs | Removes rustversion attributes from AVX-512 functions |
| src/bin/checksum.rs | Modernizes code to use is_multiple_of method |
| src/arch/x86_64/avx512_vpclmulqdq.rs | Removes rustversion attributes from all items |
| src/arch/x86_64/avx512.rs | Removes rustversion attributes and pre-1.89 fallback for xor3_vectors |
| src/arch/vpclmulqdq.rs | Entire file removed (629 lines) |
| src/arch/mod.rs | Removes duplicate version-gated update function and x86_software_update helper |
| .github/workflows/tests.yml | Removes Rust 1.81 from test matrix across all jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
We're using
rustversionto gate AVX-512 operations for Rust versions < 1.89 (when AVX-512 stabilized).The Solution
At some point, 1.89.0 will have been around long enough, we should just baseline it and remove
rustversion.Planned version bump
MINORNotes
Not doing this quite yet, just getting ready for the day we can. We'll probably draft off of the AWS Rust SDK (the largest current consumer of this crate) and go from there.