-
Notifications
You must be signed in to change notification settings - Fork 1
Start Http3 #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Start Http3 #320
Conversation
Co-Authored-By: Mahied Maruf <contact@mechite.com>
|
@mechite what do you think of this so far |
...jex-http3-flupke/src/main/java/io/avaje/jex/http3/flupke/webtransport/WebTransportEvent.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "yes". Great simple WebTransport implementation that won't bother
anyone, and HTTP3 done perfectly.
Random thought — do you think we could perhaps bump the source version
down to Java 17? Kwik and Flupke target 11, and the patches don't appear to
have any kind of requirement for newer features, though at the same time I
do see the avaje-jex-parent enforces Java 21 too...
I don't need it at all, but I'm not a fan of throwing the source version up if
it would be like a five-LOC change to potentially get more users / use cases
|
Remember that jex exclusively uses virtual threads so that we can avoid needing to implement any async stuff |
right.. didn't know that. |
Clarify that virtual threads aren't just a default or suggestion, but a hard requirement. Related-to: avaje#320 (comment) Signed-off-by: Mahied Maruf <contact@mechite.com>
|
You can put in a manual override to use a regular executor, but the whole thing was designed with virtual threads in mind |
|
random question... is the in Avaje projects the pattern I picked up was either — same package, (I don't care — but consistency is gold) |
|
consider me baffled, these transport tests are so flaky |
|
this might be the fabled udp unreliability, I can't tell if it's a client or server issue, given the total lack of java webtransport clients in the ecosystem. |
|
I think I get it, it was sending the data frames before the ssl frames, so just need a delay before sending data. |
This reverts commit da5057b.
initial draft of Http3.
part of #46
relies on ptrd/flupke#18 and ptrd/flupke#17