Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inject-events/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<dependency>
<groupId>io.avaje</groupId>
<artifactId>avaje-inject</artifactId>
<version>10.0</version>
<version>12.0</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down
20 changes: 9 additions & 11 deletions inject-events/src/main/java/io/avaje/inject/events/Event.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,18 @@
* injected:
*
* <pre>{@code
*
* @Inject
* Event<LoggedInEvent> loggedInEvent;
* @Inject
* Event<LoggedInEvent> loggedInEvent;
*
* }</pre>
*
* <p>The <code>fire()</code> method accepts an event object:
*
* <pre>{@code
*
* public void login() {
* ...
* loggedInEvent.fire(new LoggedInEvent(user));
* }
* public void login() {
* ...
* loggedInEvent.fire(new LoggedInEvent(user));
* }
*
* }</pre>
*
Expand All @@ -37,7 +35,7 @@
public abstract class Event<T> {

private static final Comparator<Observer<?>> PRIORITY = Comparator.comparing(Observer::priority);

protected final ObserverManager manager;
protected final List<Observer<T>> observers;
protected final String defaultQualifier;

Expand All @@ -46,6 +44,7 @@ protected Event(ObserverManager manager, Type type) {
}

protected Event(ObserverManager manager, Type type, String qualifier) {
this.manager = manager;
this.observers = manager.observersByType(type);
this.defaultQualifier = qualifier;
}
Expand All @@ -72,7 +71,6 @@ public void fire(T event, String qualifier) {
*/
public CompletionStage<T> fireAsync(T event, String qualifier) {
var exceptionHandler = new CollectingExceptionHandler();

return observers.stream()
.sorted(PRIORITY)
.reduce(CompletableFuture.<Void>completedFuture(null), (future, observer) ->
Expand All @@ -82,7 +80,7 @@ public CompletionStage<T> fireAsync(T event, String qualifier) {
} catch (Exception e) {
exceptionHandler.handle(e);
}
}),
}, manager.asyncExecutor()),
(future1, future2) -> future1)
.thenApply(v -> {
handleExceptions(exceptionHandler);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,33 @@

import java.lang.reflect.Type;
import java.util.List;
import java.util.concurrent.Executor;

/**
* Manages all {@link Observer} instances in the BeanScope.
* <p>
* A default implementation is provided by avaje-inject.
*
* <p>A default implementation is provided by avaje-inject.
*/
public interface ObserverManager {

/**
* Registers the given Consumer as an observer.
*
* @param <T> the type of the event
* @param <T> the type of the event
* @param eventType the type of the event ()
* @param observer the consumer to execute when a matching event is found
* @param observer the consumer to execute when a matching event is found
*/
<T> void registerObserver(Type eventType, Observer<T> observer);

/**
* Retrieves a list of all Observers registered by the given type
*
* @param <T> the Type of the Event
* @param <T> the Type of the Event
* @param eventType the type of the event
* @return all observers registered
*/
<T> List<Observer<T>> observersByType(Type eventType);

/** The Executor used for sending async events */
Executor asyncExecutor();
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,22 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.Executor;
import java.util.concurrent.ForkJoinPool;

import io.avaje.inject.PostConstruct;
import io.avaje.inject.events.Observer;
import io.avaje.inject.events.ObserverManager;

final class DObserverManager implements ObserverManager {

private final Map<Type, List<Observer<?>>> observeMap = new HashMap<>();
private final Map<Type, List<Observer<?>>> observeMap = new HashMap<>();
private Executor executor = ForkJoinPool.commonPool();

@PostConstruct
void post(Executor executor) {
this.executor = executor;
}

@Override
public <T> void registerObserver(Type type, Observer<T> observer) {
Expand All @@ -23,4 +32,9 @@ public <T> void registerObserver(Type type, Observer<T> observer) {
public List<Observer<?>> observersByType(Type eventType) {
return observeMap.computeIfAbsent(eventType, k -> new ArrayList<>());
}

@Override
public Executor asyncExecutor() {
return executor;
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package io.avaje.inject.events.spi;

import java.util.concurrent.ExecutorService;
import java.util.concurrent.ForkJoinPool;

import io.avaje.inject.BeanScopeBuilder;
import io.avaje.inject.spi.InjectPlugin;

Expand All @@ -14,5 +17,9 @@ public Class<?>[] provides() {
@Override
public void apply(BeanScopeBuilder builder) {
builder.provideDefault(null, DObserverManager.class, DObserverManager::new);
builder.addPostConstruct(
b ->
b.get(DObserverManager.class)
.post(b.getOptional(ExecutorService.class).orElse(ForkJoinPool.commonPool())));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,19 @@
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.CompletionException;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Executors;
import java.util.concurrent.atomic.AtomicBoolean;

import org.junit.jupiter.api.Test;

import io.avaje.inject.events.Observer;
import io.avaje.inject.events.ObserverManager;
import io.avaje.inject.events.events.TestEvent;
import io.avaje.inject.events.events.TestGenericEvent;
import io.avaje.inject.spi.GenericType;

class DObserverManagerTest {

ObserverManager manager = new DObserverManager();
DObserverManager manager = new DObserverManager();

@Test
void test() {
Expand All @@ -36,7 +35,7 @@ void test() {
}

@Test
void testPriority() throws InterruptedException, ExecutionException {
void testPriority() {
var l = new ArrayList<String>();

manager.<String>registerObserver(String.class, new Observer<>(0, false, s -> l.add("1"), ""));
Expand All @@ -48,42 +47,55 @@ void testPriority() throws InterruptedException, ExecutionException {
}

@Test
void testAsync() throws InterruptedException, ExecutionException {
void testAsync() {
AtomicBoolean aBoolean = new AtomicBoolean();

manager.<String>registerObserver(
String.class, new Observer<>(0, true, s -> aBoolean.set(true), ""));

new TestEvent(manager).fireAsync("str").toCompletableFuture().get();
new TestEvent(manager).fireAsync("str").toCompletableFuture().join();
assertThat(aBoolean.get()).isTrue();
}

@Test
void testAsyncPriority() throws InterruptedException, ExecutionException {
void testAsyncExecutor() {
AtomicBoolean aBoolean = new AtomicBoolean();
var exec = Executors.newSingleThreadScheduledExecutor();
manager.post(exec);
assertThat(exec).isSameAs(manager.asyncExecutor());
manager.<String>registerObserver(
String.class, new Observer<>(0, true, s -> aBoolean.set(true), ""));

new TestEvent(manager).fireAsync("str").toCompletableFuture().join();
assertThat(aBoolean.get()).isTrue();
}

@Test
void testAsyncPriority() {
var l = new ArrayList<String>();

manager.<String>registerObserver(String.class, new Observer<>(0, true, s -> l.add("1"), ""));
manager.<String>registerObserver(String.class, new Observer<>(5, true, s -> l.add("5"), ""));
manager.<String>registerObserver(String.class, new Observer<>(2, true, s -> l.add("2"), ""));

new TestEvent(manager).fireAsync("str").toCompletableFuture().get();
new TestEvent(manager).fireAsync("str").toCompletableFuture().join();
assertThat(l).containsExactly("1", "2", "5");
}

@Test
void testGenericAsync() throws InterruptedException, ExecutionException {
void testGenericAsync() {
AtomicBoolean aBoolean = new AtomicBoolean();

manager.<List<String>>registerObserver(
new GenericType<List<String>>() {}.type(),
new Observer<>(0, true, s -> aBoolean.set(true), ""));

new TestGenericEvent(manager).fireAsync(List.of("str")).toCompletableFuture().get();
new TestGenericEvent(manager).fireAsync(List.of("str")).toCompletableFuture().join();
assertThat(aBoolean.get()).isTrue();
}

@Test
void testError() throws InterruptedException {
void testError() {
final var testEvent = new TestEvent(manager);
testEvent.fire("sus");

Expand All @@ -102,7 +114,7 @@ void testError() throws InterruptedException {
}

@Test
void testAsyncError() throws InterruptedException, ExecutionException {
void testAsyncError() {
final var testEvent = new TestEvent(manager);

manager.<String>registerObserver(
Expand Down