PARTIAL sync: coreth PR #963,981,1009: nodeType w/o serialization
#1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
reviewed
Oct 15, 2025
alarso16
approved these changes
Oct 15, 2025
Contributor
alarso16
left a comment
alarso16
left a comment
There was a problem hiding this comment.
I'm still concerned about new nodes receiving an old format or old nodes receiving the new format and being unable to properly sync. If this concerned is deemed unimportant/fixed, then this looks good to me
Member
Author
The serialization changes certainly could be breaking - I will defer to @ceyonur. Additionally if they are, maybe the Granite upgrade would work well? |
JonathanOppenheimer
changed the title
nodeType and related items nodeType w/o serialization
ceyonur
reviewed
Nov 12, 2025
ceyonur
reviewed
Nov 13, 2025
Signed-off-by: Jonathan Oppenheimer <jonathan.oppenheimer@avalabs.org>
ceyonur
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This breaks up #1679