Skip to content

Conversation

@bartosz-the-coder-at-avalabs
Copy link
Contributor

@bartosz-the-coder-at-avalabs bartosz-the-coder-at-avalabs commented Nov 27, 2025

Description

https://ava-labs.atlassian.net/browse/CP-12440

Changes

  • Adds balances loading on Portfolio screen.
  • Fixes loading state on Portfolio screen.
  • Changes circular loading spinner with a page skeleton
  • Removes nested BalancesProvider components
  • Fixes hasAccountBalances function
  • Removes accumulator spread anti-pattern from BalancesProvider component

Testing

Screenshots:

https://github.com/user-attachments/assets/f9c3548b-70d5-49ea-aec2-ce2b5d3436de
https://github.com/user-attachments/assets/ce44fbbd-89bd-4e47-8c71-a869467440f0

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual change is line 53.
The rest is just the eslint formatting

Copy link
Contributor Author

@bartosz-the-coder-at-avalabs bartosz-the-coder-at-avalabs Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vvava
vvava previously approved these changes Dec 4, 2025
meeh0w
meeh0w previously approved these changes Dec 4, 2025
@bartosz-the-coder-at-avalabs bartosz-the-coder-at-avalabs merged commit 280870f into main Dec 4, 2025
5 checks passed
@bartosz-the-coder-at-avalabs bartosz-the-coder-at-avalabs deleted the bug/ng/CP-12440-acc-balance branch December 4, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants