Skip to content

Conversation

@meeh0w
Copy link
Member

@meeh0w meeh0w commented Nov 26, 2025

Changes

  1. Makes useDeriveMissingKeysForSeedless free of toast dependency from @avalabs/core-k2-components by supplying callbacks instead
  2. Makes use of the aforementioned hook in the nextgen app.
  3. Checks for missing X/P addresses as well (that will be the case with the new X/P account model)

Testing

You'll need to run the Core Seedless API locally or wait for it to be deployed to staging

Screenshots:

Before

Seedless.-.before.mov

After - but before this hook was added

Seedless.-.after.but.before.deriving.missing.keys.mov

After the hook was added

Timing is sped up to show the toast actually appears. Normally it would only show up with poor network conditions

Seedless.-.after.-.derivation.succeeded.mov

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

import { useMemo, useRef } from 'react';
import { useTranslation } from 'react-i18next';

export const SeedlessMissingKeysDerivation = () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you tell why this is a component instead of a hook?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I started out with a component for some reason and it just stayed this way. Good catch 👍

Copy link
Member Author

@meeh0w meeh0w Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be better now. These types of hooks need access to the context providers, I've created a container-like component for them all to be placed inside of, instead of throwing them all inside app.tsx.

gergelylovas
gergelylovas previously approved these changes Dec 3, 2025
gergelylovas
gergelylovas previously approved these changes Dec 3, 2025
Copy link
Contributor

@csabbee csabbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-

@gergelylovas gergelylovas merged commit 1726cd5 into main Dec 3, 2025
5 checks passed
@gergelylovas gergelylovas deleted the feat/ng-seedless-deriving-toast branch December 3, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants