-
Notifications
You must be signed in to change notification settings - Fork 17
feat(ng): derive missing keys for seedless solana & x/p #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| import { useMemo, useRef } from 'react'; | ||
| import { useTranslation } from 'react-i18next'; | ||
|
|
||
| export const SeedlessMissingKeysDerivation = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you tell why this is a component instead of a hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I started out with a component for some reason and it just stayed this way. Good catch 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be better now. These types of hooks need access to the context providers, I've created a container-like component for them all to be placed inside of, instead of throwing them all inside app.tsx.
fd95351
csabbee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Changes
useDeriveMissingKeysForSeedlessfree oftoastdependency from@avalabs/core-k2-componentsby supplying callbacks insteadTesting
You'll need to run the Core Seedless API locally or wait for it to be deployed to staging
Screenshots:
Before
Seedless.-.before.mov
After - but before this hook was added
Seedless.-.after.but.before.deriving.missing.keys.mov
After the hook was added
Timing is sped up to show the toast actually appears. Normally it would only show up with poor network conditions
Seedless.-.after.-.derivation.succeeded.mov
Checklist for the author