Avoid unnecessary RST_STREAM and PING frames causing GOAWAY messages

api/metrics/client.go

@@ -7,6 +7,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"io"
 	"net/http"
 	"net/url"
 
@@ -52,6 +53,10 @@ func (c *Client) GetMetrics(ctx context.Context) (map[string]*dto.MetricFamily,
 
 	// Return an error for any non successful status code
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
+		// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+		// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+		_, _ = io.Copy(io.Discard, resp.Body)
+
 		// Drop any error during close to report the original error
 		_ = resp.Body.Close()
 		return nil, fmt.Errorf("received status code: %d", resp.StatusCode)
@@ -60,9 +65,17 @@ func (c *Client) GetMetrics(ctx context.Context) (map[string]*dto.MetricFamily,
 	var parser expfmt.TextParser
 	metrics, err := parser.TextToMetricFamilies(resp.Body)
 	if err != nil {
+		// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+		// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+		_, _ = io.Copy(io.Discard, resp.Body)
+
 		// Drop any error during close to report the original error
 		_ = resp.Body.Close()
 		return nil, err
 	}
+
+	// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+	// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+	_, _ = io.Copy(io.Discard, resp.Body)
 	return metrics, resp.Body.Close()
 }

tests/fixture/tmpnet/check_monitoring.go

@@ -114,7 +114,12 @@ func queryLoki(
 	if err != nil {
 		return 0, stacktrace.Errorf("failed to execute request: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+		// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+		_, _ = io.Copy(io.Discard, resp.Body)
+		_ = resp.Body.Close()
+	}()
 
 	// Read and parse response
 	body, err := io.ReadAll(resp.Body)

tests/fixture/tmpnet/monitor_processes.go

@@ -591,7 +591,12 @@ func checkReadiness(ctx context.Context, url string) (bool, string, error) {
 	if err != nil {
 		return false, "", stacktrace.Errorf("request failed: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+		// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+		_, _ = io.Copy(io.Discard, resp.Body)
+		_ = resp.Body.Close()
+	}()
 
 	body, err := io.ReadAll(resp.Body)
 	if err != nil {

tests/fixture/tmpnet/node.go

@@ -224,7 +224,12 @@ func (n *Node) SaveMetricsSnapshot(ctx context.Context) error {
 	if err != nil {
 		return stacktrace.Wrap(err)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+		// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+		_, _ = io.Copy(io.Discard, resp.Body)
+		_ = resp.Body.Close()
+	}()
 	body, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return stacktrace.Wrap(err)

utils/dynamicip/ifconfig_resolver.go

@@ -31,7 +31,12 @@ func (r *ifConfigResolver) Resolve(ctx context.Context) (netip.Addr, error) {
 	if err != nil {
 		return netip.Addr{}, err
 	}
-	defer resp.Body.Close()
+	defer func() {
+		// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+		// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+		_, _ = io.Copy(io.Discard, resp.Body)
+		_ = resp.Body.Close()
+	}()
 
 	ipBytes, err := io.ReadAll(resp.Body)
 	if err != nil {

utils/rpc/json.go

@@ -7,6 +7,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"io"
 	"net/http"
 	"net/url"
 
@@ -49,15 +50,27 @@ func SendJSONRequest(
 
 	// Return an error for any non successful status code
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
+		// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+		// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+		_, _ = io.Copy(io.Discard, resp.Body)
+
 		// Drop any error during close to report the original error
 		_ = resp.Body.Close()
 		return fmt.Errorf("received status code: %d", resp.StatusCode)
 	}
 
 	if err := rpc.DecodeClientResponse(resp.Body, reply); err != nil {
+		// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+		// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+		_, _ = io.Copy(io.Discard, resp.Body)
+
 		// Drop any error during close to report the original error
 		_ = resp.Body.Close()
 		return fmt.Errorf("failed to decode client response: %w", err)
 	}
+
+	// Avoid sending unnecessary RST_STREAM and PING frames by ensuring the whole body is read.
+	// See https://blog.cloudflare.com/go-and-enhance-your-calm/#reading-bodies-in-go-can-be-unintuitive
+	_, _ = io.Copy(io.Discard, resp.Body)
 	return resp.Body.Close()
 }