[tooling] Update to use go tool for mockgen and canoto #4479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
force-pushed
the
maru/go-tool-cleanup
branch
from
04fc0fb to
8c723ed
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to use go tool for running mockgen and canoto instead of go run, leveraging Go 1.24's improved tool support. The changes eliminate the need for a separate tools.go file by declaring these tools directly in go.mod.
Key Changes:
- Migrated mock generation commands from
go run go.uber.org/mock/mockgentogo tool mockgen - Migrated canoto generation commands from
go run github.com/StephenButtolph/canoto/canototogo tool canoto - Added tool declarations to
go.modand removed the obsoletetools.gofile
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Added tool block declaring mockgen, canoto, and ginkgo; moved golang.org/x/mod to indirect dependencies |
| tools.go | Removed obsolete tools import file |
| Taskfile.yml | Updated generate task commands to use simplified tool names |
| Various *_generate_test.go files | Updated go:generate directives to use go tool mockgen instead of go run |
| simplex/*.go and snow/engine/snowman/block/block_context_vm.go | Updated go:generate directives to use go tool canoto instead of go run |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
StephenButtolph
approved these changes
Nov 6, 2025
joshua-kim
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
During the transition to go tool as of 1.24, mockgen and canoto were not added our tools module (tools/go.mod) due to not wanting to risk version skew between our tools module and the main go module. But that just means we can use
go toolagainst our main go.mod.How this was tested
CI
Need to be documented in RELEASES.md?
N/A