Fixing compilation error in some platforms due to invalid conversion in setNormalOneShotMode()

[arduinoenigma]

Pull request #128 gave compilation errors on some platforms, an invalid conversion in setNormalOneShotMode()

In Arduino 2.3.5 with Preferences->Compiler Warnings->All did not complain at all
In Arduino 1.8.19 with Preferences->Compiler Warnings->All throws that same message as a warning, not an error.

The error is here:

MCP2515::ERROR MCP2515::setNormalOneShotMode()
{
return setMode(CANCTRL_REQOP_NORMAL | CANCTRL_OSM);
}

The setMode function expects a (CANCTRL_REQOP_MODE) where the | operand returns an int

Since CANCTRL_REQOP_NORMAL is defined as 0x00; this error can be fixed by adding CANCTRL_REQOP_OSM to the CANCTRL_REQOP_MODE enum.

in mcp2515.h

    enum /*class*/ CANCTRL_REQOP_MODE : uint8_t {
        CANCTRL_REQOP_NORMAL     = 0x00,
        CANCTRL_REQOP_OSM        = 0x08,
        CANCTRL_REQOP_SLEEP      = 0x20,
        CANCTRL_REQOP_LOOPBACK   = 0x40,
        CANCTRL_REQOP_LISTENONLY = 0x60,
        CANCTRL_REQOP_CONFIG     = 0x80,
        CANCTRL_REQOP_POWERUP    = 0xE0
    };

and changing in mcp2515.cpp

MCP2515::ERROR MCP2515::setNormalOneShotMode()
{
return setMode(CANCTRL_REQOP_OSM);
}

Now it compiles without warnings/errors.

[autowp]

@arduinoenigma may i ask you to squash changes into single commit?

[arduinoenigma]

Had to close this PR to add all the changes under one commit

[PhilippeArdit]

Hi, May I remind you of the interest of this PR? : PR #46 opened on Sep 12, 2020 by jxltom : Fix messages are not read in correct order ? #46 Fix messages are not read in correct order by jxltom · Pull Request #46 · autowp/arduino-mcp2515 github.com Regards Philippe Nb : si vous recevez ce courriel pendant vos temps non travaillés, il ne requiert ni prise de connaissance, ni réponse immédiate de votre part. Le 20 sept. 2025 à 21:01, Arduino Enigma ***@***.***> a écrit : arduinoenigma left a comment (autowp/arduino-mcp2515#130) <#130 (comment)> Had to close this PR to add all the changes under one commit — Reply to this email directly, view it on GitHub <#130 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLHPCSKWACVTRVRJFIDBTD3TWQAFAVCNFSM6AAAAACG5PXMOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJVGE3TKOBWGM>. You are receiving this because you are subscribed to this thread.