Skip to content

Conversation

@efeecllk
Copy link

@efeecllk efeecllk commented Nov 12, 2025

Related Issue

Fixes #28

Related Issue

Closes #28

Problem

As reported in #28, the documentation uses port 8317 but VibeProxy actually runs on 8318...

Summary by CodeRabbit

  • Documentation
    • Updated server port configuration from 8317 to 8318
    • Updated Factory CLI configuration examples and API endpoint references to reflect new port settings

@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Walkthrough

The FACTORY_SETUP.md documentation has been updated to correct port number references from 8317 to 8318 throughout the document, including server startup notes and Factory CLI base_url configuration examples.

Changes

Cohort / File(s) Summary
Documentation port correction
FACTORY_SETUP.md
Updated all port references from 8317 to 8318 across server startup instructions and Factory CLI base_url configuration examples to match actual CLIProxyAPI port configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A port was wrong, oh what a plight,
Eight-three-one-seven? No, that's not right!
Eight-three-one-eight, the truth we found,
Now docs and servers are perfectly bound! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: fixing port references from 8317 to 8318 in FACTORY_SETUP.md, directly addressing the documented issue.
Linked Issues check ✅ Passed The PR successfully addresses all coding-related objectives from issue #28: updating all port references from 8317 to 8318 in FACTORY_SETUP.md to match actual runtime configuration.
Out of Scope Changes check ✅ Passed The PR contains only in-scope changes—port number updates in FACTORY_SETUP.md documentation. No unrelated modifications to code, configuration, or other files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a57c9e0 and 612e4ce.

📒 Files selected for processing (1)
  • FACTORY_SETUP.md (2 hunks)
🔇 Additional comments (2)
FACTORY_SETUP.md (2)

45-45: Port reference updates in configuration section are complete and consistent.

All user-facing base_url entries have been correctly updated from 8317 to 8318 across both Anthropic and OpenAI model configurations, and the server startup note reflects the correct port. The configuration examples are now aligned with the actual runtime port.

Also applies to: 57-57, 64-64, 71-71, 78-78, 85-85, 93-93, 100-100, 107-107, 114-114, 121-121, 128-128, 135-135, 142-142, 149-149


207-207: Verify completeness of port reference updates in non-configuration sections.

The PR updated all user-facing configuration examples to port 8318, but three references to port 8317 remain unchanged in different sections:

  • Line 207 (Troubleshooting): "Port 8317 already in use"
  • Line 238 (Extended Thinking): "intercepts requests on port 8317"
  • Line 263 (Tips): "releases port 8317"

Per the PR objective to "update all port references in the documentation to 8318," clarify whether these should also be updated or if they intentionally refer to an internal component port (e.g., ThinkingProxy).

If these references should remain as internal implementation details, consider adding a clarifying note to avoid user confusion. If they should be updated to 8318, apply the fixes.

Also applies to: 238-238, 263-263


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ranaroussi
Copy link
Member

Thank you for the PR, but closing this as it's based on a misunderstanding of the architecture.

The current documentation is correct. VibeProxy uses a two-tier proxy architecture:

  1. ThinkingProxy (port 8317) ← Users connect here
  2. CLIProxyAPI (port 8318) ← Internal backend only

The ThinkingProxy intercepts requests on port 8317 to add extended thinking parameters for Claude models, then forwards them to CLIProxyAPI on port 8318.

Evidence from the codebase:

  • src/Sources/ThinkingProxy.swift line 21: let proxyPort: UInt16 = 8317
  • src/Sources/ThinkingProxy.swift line 22: private let targetPort: UInt16 = 8318
  • src/Sources/AppDelegate.swift line 169: User always connects to 8317 (thinking proxy)

Changing all documentation references from 8317 to 8318 would break the setup for all users.

If you experienced 401 errors, they were likely caused by a different issue (authentication, server not running, etc.), not the port number. Feel free to open a new issue if you're still experiencing problems and we can help debug!

@ranaroussi ranaroussi closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation uses incorrect port 8317 instead of actual port 8318

2 participants