Skip to content

fix: prevent possible slow resolution of rate limiter #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sam-super wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent possible slow resolution of rate limiter #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions src/wrappers/rateLimit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,26 +9,14 @@ function rateLimitWrapper(client, { jwksRequestsPerMinute = 10 }) {
const limiter = new RateLimiter(jwksRequestsPerMinute, 'minute', true);
logger(`Configured rate limiting to JWKS endpoint at ${jwksRequestsPerMinute}/minute`);

return async (kid) => await new Promise((resolve, reject) => {
limiter.removeTokens(1, async (err, remaining) => {
if (err) {
reject(err);
}

logger('Requests to the JWKS endpoint available for the next minute:', remaining);
if (remaining < 0) {
logger('Too many requests to the JWKS endpoint');
reject(new JwksRateLimitError('Too many requests to the JWKS endpoint'));
} else {
try {
const key = await getSigningKey(kid);
resolve(key);
} catch (error) {
reject(error);
}
}
});
});
return async (kid) => {
logger('Requests to the JWKS endpoint available for the next minute:', limiter.getTokensRemaining());
if (limiter.tryRemoveTokens(1)) {
return getSigningKey(kid);
}
logger('Too many requests to the JWKS endpoint');
throw new JwksRateLimitError('Too many requests to the JWKS endpoint');
};
}

module.exports.default = rateLimitWrapper;