fix: prevent OAuth parameter injection via returnTo (#2381) #2413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a security issue where OAuth parameters could be injected via the
returnToparameter inwithPageAuthRequired.Changes
returnToparameter to prevent injection of OAuth parameters like&prompt=loginRelated PRs
Testing
All existing tests pass, plus 3 new test cases specifically for this issue:
Note: This PR originally contained an attribution error in the commit message. The security issue was discovered and fixed by Joshua Rogers (@MegaManSec) in #2381. See correction comment below.