Skip to content

fix(app-router): encode returnTo in login redirect to prevent OAuth param injection #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −1
Closed

fix(app-router): encode returnTo in login redirect to prevent OAuth param injection #2381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/helpers/with-page-auth-required.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
: opts.returnTo;
const { redirect } = await import("next/navigation.js");
redirect(
`${config.loginUrl}${opts.returnTo ? `?returnTo=${returnTo}` : ""}`
`${config.loginUrl}${opts.returnTo ? `?returnTo=${encodeURIComponent(returnTo)}` : ""}`

Check failure on line 199 in src/server/helpers/with-page-auth-required.ts

View workflow job for this annotation

GitHub Actions / Build Package 

Argument of type 'string | undefined' is not assignable to parameter of type 'string | number | boolean'.

Check failure on line 199 in src/server/helpers/with-page-auth-required.ts

View workflow job for this annotation

GitHub Actions / Lint Code 

Argument of type 'string | undefined' is not assignable to parameter of type 'string | number | boolean'.
);
}
return handler(params);
Expand Down
Loading