Implement resources as references #2015
Open
+474
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following OTP, make resources appear as references to Erlang code. Also following OTP, make resources comparable and serializable, with the same properties. For a resource to be properly unserialized, it must still exist in the VM. Also fix a bug with reference ticks where the top 32 bits were incorrectly handled on 32 bits platforms, yielding collisions of `make_ref/0`. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following OTP, make resources appear as references to Erlang code. Also following OTP, make resources comparable and serializable, with the same properties. For a resource to be properly unserialized, it must still exist in the VM.
Also fix a bug with reference ticks where the top 32 bits were incorrectly handled on 32 bits platforms, yielding collisions of
make_ref/0.This PR does not modify code that manipulates resources to take advantage of this change. For example, socket code now generates sockets as a tuple with two references (the resource and another reference that was added to ease matching when the resource was an empty binary). Optimization of these structures and possible alignment with OTP will be part of a continuation PR.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later