-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Automatic kernel config rewrite
#8889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
@vidplace7 Please review change in rv1106 as there are many changes. |
rpardini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Sure. I think you also have rights to do that. |
5f7672a to
4116095
Compare
rpardini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better now.
the rv1106-vendor stuff seems drastic, probably because it was very outdated. If I understand, rv1106 is an armhf version using rk vendor kernel, and used for very RAM-limited boards. We might need to have a way to opt-out from (some?) for armbian-kernel.sh for those usecases.
I'd merge anyway, and rv1106 can individually revert and rework later if needed.
|
✅ This PR has been reviewed and approved — all set for merge! |
vidplace7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vidplace7 Please review change in rv1106 as there are many changes.
Still compiles / boots fine. Memory usage appears to be the same.
The only concerning thing here to me is that all of the USB wifi driver modules have been removed? 😬 How can I get those to persist?
I want attempting to manually include all of the usb based chipsets as =m to give some flexibility to the user (since it did not seem to make a large difference in kernel memory usage)
Weird indeed. I didn't find a quick solution, so I removed this kernel from automation. Testing atm. |
4116095 to
02acc11
Compare
I rework the script that knows exceptions now. Closing this PR in favor of #8895 |
Rewrite kernel configs
What this PR does
./compile.sh rewrite-kernel-configfor each scheduled (family, branch) and aggregates all changes into one PR.How it was produced
This PR is produced from this GHA script.
./compile.sh inventory-boards(deduped, sanitized).rewrite-kernel-configper matrix.Review tips
Files changed
Files: 65 • Lines: +380 / -306 (Δ 74)