Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 72 additions & 27 deletions Package.resolved

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ let package = Package(
.library(name: "web3-zksync.swift", targets: ["web3-zksync"])
],
dependencies: [
.package(url: "https://github.com/attaswift/BigInt", from: "5.3.0"),
.package(url: "https://github.com/attaswift/BigInt", from: "5.7.0"),
.package(url: "https://github.com/iwill/generic-json-swift", .upToNextMajor(from: "2.0.2")),
.package(url: "https://github.com/GigaBitcoin/secp256k1.swift.git", .upToNextMajor(from: "0.6.0")),
.package(url: "https://github.com/21-DOT-DEV/swift-secp256k1", exact: "0.21.1"),
.package(url: "https://github.com/vapor/websocket-kit.git", from: "2.16.1"),
.package(url: "https://github.com/apple/swift-log.git", from: "1.6.4")
],
Expand All @@ -29,7 +29,7 @@ let package = Package(
.target(name: "Internal_CryptoSwift_PBDKF2"),
"BigInt",
.product(name: "GenericJSON", package: "generic-json-swift"),
.product(name: "secp256k1", package: "secp256k1.swift"),
.product(name: "P256K", package: "swift-secp256k1"),
.product(name: "WebSocketKit", package: "websocket-kit"),
.product(name: "Logging", package: "swift-log")
],
Expand Down
6 changes: 3 additions & 3 deletions Package@swift-6.1.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ let package = Package(
.library(name: "web3-zksync.swift", targets: ["web3-zksync"])
],
dependencies: [
.package(url: "https://github.com/attaswift/BigInt", from: "5.3.0"),
.package(url: "https://github.com/attaswift/BigInt", from: "5.7.0"),
.package(url: "https://github.com/iwill/generic-json-swift", .upToNextMajor(from: "2.0.2")),
.package(url: "https://github.com/GigaBitcoin/secp256k1.swift.git", .upToNextMajor(from: "0.6.0")),
.package(url: "https://github.com/21-DOT-DEV/swift-secp256k1", exact: "0.21.1"),
.package(url: "https://github.com/vapor/websocket-kit.git", from: "2.16.1"),
.package(url: "https://github.com/apple/swift-log.git", from: "1.6.4")
],
Expand All @@ -29,7 +29,7 @@ let package = Package(
.target(name: "Internal_CryptoSwift_PBDKF2"),
"BigInt",
.product(name: "GenericJSON", package: "generic-json-swift"),
.product(name: "secp256k1", package: "secp256k1.swift"),
.product(name: "P256K", package: "swift-secp256k1"),
.product(name: "WebSocketKit", package: "websocket-kit"),
.product(name: "Logging", package: "swift-log")
],
Expand Down
4 changes: 2 additions & 2 deletions web3sTests/Account/EthereumKeyStorageTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class EthereumKeyStorageTests: XCTestCase {
}

func testStoreLocalPrivateKey() {
let randomData = Data.randomOfLength(256)!
let randomData = Data.randomOfLength(32)!
let keyStorage = EthereumKeyLocalStorage()

do {
Expand All @@ -29,7 +29,7 @@ class EthereumKeyStorageTests: XCTestCase {
}

func testStoreAndLoadLocalPrivateKey() {
let randomData = Data.randomOfLength(256)!
let randomData = Data.randomOfLength(32)!
let keyStorage = EthereumKeyLocalStorage()
let ethereumAddress = EthereumAddress(TestConfig.publicKey)
do {
Expand Down
48 changes: 30 additions & 18 deletions web3swift/src/Account/EthereumKeyStorage.swift
Original file line number Diff line number Diff line change
Expand Up @@ -31,50 +31,59 @@ public class EthereumKeyLocalStorage: EthereumSingleKeyStorageProtocol, @uncheck
private let address: ThreadSafeBox<EthereumAddress?> = ThreadSafeBox(nil)
private let localFileName = "ethereumkey"

private var addressPath: String? {
private var addressURL: URL? {
guard let address = address.value else {
return nil
}
if let url = folderPath {
return url.appendingPathComponent(address.asString()).path
return url.appendingPathComponent(address.asString())
}
return nil
}

private var addressPath: String? { addressURL?.path }

private var folderPath: URL? {
if let url = fileManager.urls(for: .cachesDirectory, in: .userDomainMask).first {
return url
}
return nil
}

private var localURL: URL? {
fileManager
.urls(for: .cachesDirectory, in: .userDomainMask)
.first?
.appendingPathComponent(localFileName)
}

private var localPath: String? {
if let url = fileManager.urls(for: .cachesDirectory, in: .userDomainMask).first {
return url.appendingPathComponent(localFileName).path
}
return nil
localURL?.path
}

private let fileManager = FileManager.default

public func storePrivateKey(key: Data) throws {
guard let localPath else {
guard let localURL else {
throw EthereumKeyStorageError.failedToSave
}

let success = NSKeyedArchiver.archiveRootObject(key, toFile: localPath)

if !success {
do {
try NSKeyedArchiver
.archivedData(withRootObject: key, requiringSecureCoding: false)
.write(to: localURL)
} catch {
throw EthereumKeyStorageError.failedToSave
}
}

public func loadPrivateKey() throws -> Data {
guard let localPath else {
guard let localURL else {
throw EthereumKeyStorageError.failedToLoad
}

guard let data = NSKeyedUnarchiver.unarchiveObject(withFile: localPath) as? Data else {
guard let archivedData = try? Data(contentsOf: localURL),
let data = try NSKeyedUnarchiver.unarchivedObject(ofClass: NSData.self, from: archivedData) as? Data else {
throw EthereumKeyStorageError.failedToLoad
}

Expand Down Expand Up @@ -112,13 +121,15 @@ extension EthereumKeyLocalStorage: EthereumMultipleKeyStorageProtocol {
}
}

guard let localPath = self.addressPath else {
guard let localURL = self.addressURL else {
throw EthereumKeyStorageError.failedToSave
}

let success = NSKeyedArchiver.archiveRootObject(key, toFile: localPath)

if !success {
do {
try NSKeyedArchiver
.archivedData(withRootObject: key, requiringSecureCoding: false)
.write(to: localURL)
} catch {
throw EthereumKeyStorageError.failedToSave
}
}
Expand All @@ -134,11 +145,12 @@ extension EthereumKeyLocalStorage: EthereumMultipleKeyStorageProtocol {
}
}

guard let localPath = self.addressPath else {
guard let localURL = self.addressURL else {
throw EthereumKeyStorageError.failedToLoad
}

guard let data = NSKeyedUnarchiver.unarchiveObject(withFile: localPath) as? Data else {
guard let archivedData = try? Data(contentsOf: localURL),
let data = try NSKeyedUnarchiver.unarchivedObject(ofClass: NSData.self, from: archivedData) as? Data else {
throw EthereumKeyStorageError.failedToLoad
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ extension EthereumAddress: ABIType {
}
}

extension BigInt: @unchecked Sendable {}
extension BigUInt: @unchecked Sendable {}

extension BigInt: ABIType {
public static var rawType: ABIRawType { .FixedInt(256) }
public static var parser: ParserFunction {
Expand Down
11 changes: 9 additions & 2 deletions web3swift/src/Extensions/HexExtensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import Foundation

public extension BigUInt {
init?(hex: String) {
self.init(hex.web3.noHexPrefix.lowercased(), radix: 16)
self.init(hex.web3.noHexPrefix.web3.orZero.lowercased(), radix: 16)
}
}

Expand All @@ -24,7 +24,7 @@ public extension Web3Extensions where Base == BigUInt {

public extension BigInt {
init?(hex: String) {
self.init(hex.web3.noHexPrefix.lowercased(), radix: 16)
self.init(hex.web3.noHexPrefix.web3.orZero.lowercased(), radix: 16)
}
}

Expand Down Expand Up @@ -79,6 +79,13 @@ public extension Web3Extensions where Base == String {
return base
}

var orZero: String {
if base.isEmpty {
return "0"
}
return base
}

var stringValue: String {
if let byteArray = try? HexUtil.byteArray(fromHex: base.web3.noHexPrefix), let str = String(bytes: byteArray, encoding: .utf8) {
return str
Expand Down
Loading
Loading