Increase timeout duration for link check #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "markdown-link-check" tool is used to check for broken links in the project's Markdown files. In addition to the obvious case where a broken link is indicated by an HTTP response status code, the case where the server does not respond must also be covered. By default, "markdown-link-check" waits 10 s for a response, and considers the link broken if one was not received in that time. It has been found that it occasionally takes more than 10 s to receive a response from some functional links, and thus the default timeout value was resulting in disruptive false positives from the link check.
per1234
added
type: enhancement
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "markdown-link-check" tool is used to check for broken links in the project's Markdown files.
In addition to the obvious case where a broken link is indicated by an HTTP response status code, the case where the server does not respond must also be covered. By default, "markdown-link-check" waits 10 s for a response, and considers the link broken if one was not received in that time. It has been found that it occasionally takes more than 10 s to receive a response from some functional links, and thus the default timeout value was resulting in disruptive false positives from the link check.
This is a pull from the downstream asset enhancement/fix: arduino/arduino-lint#765
Related: arduino/arduino-cli#1764