[PC-1877] Pro 4G Module: AT Commands Post-Feedback Update #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/user-manual/content.md Co-authored-by: Julián Caro Linares <jcarolinares@gmail.com>
ArduinoBot
added
documentation
Preview Deployment🚀 Preview this PR: https://67202ac07c30239d01f7384a--docs-content.netlify.app |
jcarolinares
requested changes
Oct 22, 2024
Contributor
jcarolinares
left a comment
jcarolinares
left a comment
There was a problem hiding this comment.
Review done
@TaddyHC please check and ping me again
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Show resolved
Hide resolved
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Show resolved
Hide resolved
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Show resolved
Hide resolved
content/hardware/04.pro/carriers/portenta-mid-carrier/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/carriers/portenta-mid-carrier/tutorials/user-manual/content.md
Show resolved
Hide resolved
content/hardware/04.pro/carriers/portenta-mid-carrier/tutorials/user-manual/content.md
Outdated
Show resolved
Hide resolved
Contributor
|
@jcarolinares thanks for the feedback. I have made the updates per observation. Let me know if additional update is required please! |
MaxPayne86
reviewed
Oct 23, 2024
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Outdated
Show resolved
Hide resolved
MaxPayne86
reviewed
Oct 23, 2024
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Outdated
Show resolved
Hide resolved
MaxPayne86
reviewed
Oct 23, 2024
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Outdated
Show resolved
Hide resolved
MaxPayne86
reviewed
Oct 23, 2024
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Outdated
Show resolved
Hide resolved
MaxPayne86
reviewed
Oct 23, 2024
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Outdated
Show resolved
Hide resolved
MaxPayne86
reviewed
Oct 23, 2024
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Show resolved
Hide resolved
MaxPayne86
reviewed
Oct 23, 2024
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Outdated
Show resolved
Hide resolved
MaxPayne86
reviewed
Oct 23, 2024
content/hardware/04.pro/carriers/portenta-max-carrier/tutorials/mpcie-4g-modem/content.md
Outdated
Show resolved
Hide resolved
Contributor
|
@TaddyHC I see you perform @MaxPayne86 feedback, that is great please tell me when you think we are ready to publish |
Contributor
|
Thanks @MaxPayne86 and @jcarolinares for the important feedback! The updates have been made to address the feedback, and I hope they now present the information as it should. Please let me know your thoughts and if we should proceed with further review. Otherwise, I think we could move on to the next steps. |
jcarolinares
approved these changes
Oct 29, 2024
Contributor
jcarolinares
left a comment
jcarolinares
left a comment
There was a problem hiding this comment.
Let's be practical and and publish this, this is ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Updates the Portenta Mid Carrier user manual and AT commands with Pro 4G Module related documentation post feedback from Massimo Pennazio.
Contribution Guidelines