Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/arduino-app-cli/brick/details.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (

"github.com/spf13/cobra"

"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/completion"
"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/internal/servicelocator"
"github.com/arduino/arduino-app-cli/cmd/feedback"
"github.com/arduino/arduino-app-cli/internal/orchestrator/bricks"
Expand All @@ -36,6 +37,7 @@ func newBricksDetailsCmd(cfg config.Configuration) *cobra.Command {
Run: func(cmd *cobra.Command, args []string) {
bricksDetailsHandler(args[0], cfg)
},
ValidArgsFunction: completion.BrickIDs(),
}
}

Expand Down
22 changes: 22 additions & 0 deletions cmd/arduino-app-cli/completion/completion.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/internal/servicelocator"
"github.com/arduino/arduino-app-cli/cmd/feedback"
"github.com/arduino/arduino-app-cli/internal/orchestrator"
"github.com/arduino/arduino-app-cli/internal/orchestrator/bricks"
"github.com/arduino/arduino-app-cli/internal/orchestrator/config"
)

Expand Down Expand Up @@ -97,3 +98,24 @@ func ApplicationNamesWithFilterFunc(cfg config.Configuration, filter func(apps o
return res, cobra.ShellCompDirectiveNoFileComp
}
}

func BrickIDs() cobra.CompletionFunc {
return BrickIDsWithFilterFunc(func(_ bricks.BrickListItem) bool { return true })
}

func BrickIDsWithFilterFunc(filter func(apps bricks.BrickListItem) bool) cobra.CompletionFunc {
return func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
brickList, err := servicelocator.GetBrickService().List()
if err != nil {
return nil, cobra.ShellCompDirectiveError
}

var res []string
for _, brick := range brickList.Bricks {
if filter(brick) {
res = append(res, brick.ID)
}
}
return res, cobra.ShellCompDirectiveNoFileComp
}
}