Skip to content

chore: add license check #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 17, 2025
Merged

chore: add license check #4

merged 8 commits into from
Oct 17, 2025
+497,063 −4,777

Conversation

@lucarin91
Copy link
Contributor

@lucarin91 lucarin91 commented Oct 17, 2025 •
edited
Loading

Add dependency licenses and CI checks

@lucarin91
Copy link
Contributor Author

lucarin91 commented Oct 17, 2025

For some reasons the task update-deb-copyright panics with the following error

Writing notices for arduino-app-cli to /Users/sedia/repo/arduino-app-cli/.licenses/arduino-app-cli/NOTICE
/opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:75:in 'Array#map': undefined method 'strip' for nil (NoMethodError)

          #{texts.map(&:strip).reject(&:empty?).compact.join(TEXT_SEPARATOR)}
                 ^^^^
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:75:in 'Licensed::Reporters::NoticesReporter#notices'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:27:in 'block (2 levels) in Licensed::Reporters::NoticesReporter#end_report_app'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:27:in 'Array#map'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:27:in 'block in Licensed::Reporters::NoticesReporter#end_report_app'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:23:in 'IO.open'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:23:in 'Licensed::Reporters::NoticesReporter#end_report_app'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:114:in 'Licensed::Commands::Command#run_app'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:67:in 'block in Licensed::Commands::Command#run_command'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:64:in 'Array#map'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:64:in 'Licensed::Commands::Command#run_command'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:23:in 'Licensed::Commands::Command#run'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/cli.rb:115:in 'Licensed::CLI#run'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/cli.rb:57:in 'Licensed::CLI#notices'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/thor-1.3.2/lib/thor/command.rb:28:in 'Thor::Command#run'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/thor-1.3.2/lib/thor/invocation.rb:127:in 'Thor::Invocation#invoke_command'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/thor-1.3.2/lib/thor.rb:538:in 'Thor.dispatch'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/thor-1.3.2/lib/thor/base.rb:584:in 'Thor::Base::ClassMethods#start'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/exe/licensed:5:in '<top (required)>'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/bin/licensed:25:in 'Kernel#load'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/bin/licensed:25:in '<main>'

I think there is some invalid files

@lucarin91
Copy link
Contributor Author

lucarin91 commented Oct 17, 2025

For some reasons the task update-deb-copyright panics with the following error

Writing notices for arduino-app-cli to /Users/sedia/repo/arduino-app-cli/.licenses/arduino-app-cli/NOTICE
/opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:75:in 'Array#map': undefined method 'strip' for nil (NoMethodError)

          #{texts.map(&:strip).reject(&:empty?).compact.join(TEXT_SEPARATOR)}
                 ^^^^
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:75:in 'Licensed::Reporters::NoticesReporter#notices'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:27:in 'block (2 levels) in Licensed::Reporters::NoticesReporter#end_report_app'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:27:in 'Array#map'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:27:in 'block in Licensed::Reporters::NoticesReporter#end_report_app'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:23:in 'IO.open'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/reporters/notices_reporter.rb:23:in 'Licensed::Reporters::NoticesReporter#end_report_app'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:114:in 'Licensed::Commands::Command#run_app'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:67:in 'block in Licensed::Commands::Command#run_command'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:64:in 'Array#map'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:64:in 'Licensed::Commands::Command#run_command'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/commands/command.rb:23:in 'Licensed::Commands::Command#run'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/cli.rb:115:in 'Licensed::CLI#run'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/lib/licensed/cli.rb:57:in 'Licensed::CLI#notices'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/thor-1.3.2/lib/thor/command.rb:28:in 'Thor::Command#run'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/thor-1.3.2/lib/thor/invocation.rb:127:in 'Thor::Invocation#invoke_command'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/thor-1.3.2/lib/thor.rb:538:in 'Thor.dispatch'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/thor-1.3.2/lib/thor/base.rb:584:in 'Thor::Base::ClassMethods#start'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/gems/licensed-5.0.4/exe/licensed:5:in '<top (required)>'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/bin/licensed:25:in 'Kernel#load'
        from /opt/homebrew/Cellar/licensed/5.0.4/libexec/bin/licensed:25:in '<main>'

I think there is some invalid files

solved there was one .dep file that had an empty source:, probably licensed should handle that better 😅

@lucarin91 lucarin91 requested review from dido18 and per1234 October 17, 2025 15:01
@lucarin91 lucarin91 marked this pull request as ready for review October 17, 2025 15:01
@lucarin91 lucarin91 mentioned this pull request Oct 17, 2025
Merged
@lucarin91 lucarin91 merged commit d4409ec into main Oct 17, 2025
6 checks passed
@lucarin91 lucarin91 deleted the add-license-check branch October 17, 2025 15:24
lucarin91 added a commit that referenced this pull request Oct 28, 2025
@lucarin91
chore: add license check (#4)
7a8272c 
* chore: add licenses check

* fix license

* fix notice build

* update notice and copyright

* add check license workflow

* update licenses

* update licence of compress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giulio93 giulio93 giulio93 approved these changes

@Xayton Xayton Xayton approved these changes

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

@per1234 per1234 Awaiting requested review from per1234

@dido18 dido18 Awaiting requested review from dido18

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucarin91 @giulio93 @Xayton @MatteoPologruto