Skip to content

Conversation

@dido18
Copy link
Contributor

@dido18 dido18 commented Nov 28, 2025

Motivation

The HTTP panics if an app does not have a sketch folder in the list of libraries (and possibly other endpoints).

Change description

  • make the field MainSketchPath private
  • add the GetSketchPath() (*paths.Path, bool) method to retrieve the sketch path
  • fix the panic in other parts of the code
  • add unit tests

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@dido18 dido18 marked this pull request as ready for review November 28, 2025 13:42
@dido18 dido18 requested a review from a team November 28, 2025 13:46
@dido18 dido18 changed the title fix: check if the sketch path is not nill fix: manage missing sketch folder Nov 28, 2025
@dido18 dido18 merged commit 3687b09 into main Nov 28, 2025
6 checks passed
@dido18 dido18 deleted the fix-nil-sketch-path branch November 28, 2025 19:01
@per1234 per1234 added the bug Something isn't working label Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/v1/apps/{appID}/sketch/libraries endpoint causes panic when App doesn't contain sketch

4 participants