Skip to content

Conversation

@mirkoCrobu
Copy link
Contributor

Motivation

closes #113

Currently, an app’s Python script is handled as an optional module by design.
This assumption is incorrect: every App must always include a Python script.

Change Description

  • Identify all the logic that treats the Python script as optional and make it mandatory.
  • Ensure proper handling of cases where the script cannot be created, including related error paths.
  • Update existing tests to reflect this change, or add missing ones if needed.
  • Update the createApp endpoint by removing the skipPython flag, and revise the OpenAPI spec and e2e tests accordingly.

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@mirkoCrobu mirkoCrobu self-assigned this Nov 27, 2025
@mirkoCrobu mirkoCrobu added bug Something isn't working enhancement New feature or request labels Nov 27, 2025
@lucarin91 lucarin91 self-requested a review November 28, 2025 12:07
Copy link
Contributor

@lucarin91 lucarin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the tests?

@mirkoCrobu mirkoCrobu requested a review from lucarin91 November 28, 2025 12:24
@mirkoCrobu mirkoCrobu merged commit 86853c9 into main Nov 28, 2025
6 checks passed
@mirkoCrobu mirkoCrobu deleted the issue_113_python_should_be_mandatory branch November 28, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] App Python script should not be optional

2 participants