make example code optional for brick example details #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dido18
reviewed
Oct 21, 2025
Contributor
dido18
left a comment
dido18
left a comment
There was a problem hiding this comment.
I would add unit tests where possible to avoid regression
lucarin91
reviewed
Oct 21, 2025
Contributor
lucarin91
left a comment
lucarin91
left a comment
There was a problem hiding this comment.
LGTM, but do you think we are able to add a test for this. AFAIK, we already have some testdata, maybe it isn't too complicated to do it.
lucarin91
reviewed
Oct 23, 2025
dido18
reviewed
Oct 23, 2025
Contributor
dido18
left a comment
dido18
left a comment
There was a problem hiding this comment.
Nice to have Test 🦸
I suggest simplifying the code of the example, (e.g remoe png and other stuff not needed) and keep only the files that we need to test
.licensed.yml
Outdated
| apps: | ||
| - source_path: ./cmd/arduino-app-cli | ||
|
|
||
|
|
Contributor
Author
|
Replaced by : #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #795
Change description
Some bricks don't have any code example folder.
In this case, we should return null for the field "code_examples" when calling /v1/bricks/{brick_id}
Additional Notes
Reviewer checklist
main.