Skip to content

SPI: fix data mode settings #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

SPI: fix data mode settings #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a08679
spi: fix data mode settings
pennam Nov 11, 2025
555c598
spi: fix typo
pennam Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions libraries/SPI/SPI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,25 +83,25 @@ void arduino::ZephyrSPI::beginTransaction(SPISettings settings) {
case SPI_MODE0:
break;
case SPI_MODE1:
mode = SPI_MODE_CPHA;
mode |= SPI_MODE_CPHA;
break;
case SPI_MODE2:
mode = SPI_MODE_CPOL;
mode |= SPI_MODE_CPOL;
break;
case SPI_MODE3:
mode = SPI_MODE_CPOL | SPI_MODE_CPHA;
mode |= SPI_MODE_CPOL | SPI_MODE_CPHA;
break;
}

// Set SPI configuration structure for 8-bit transfers
memset(&config, 0, sizeof(struct spi_config));
config.operation = mode | SPI_WORD_SET(8);
config.frequency = max(SPI_MIN_CLOCK_FEQUENCY, settings.getClockFreq());
config.frequency = max(SPI_MIN_CLOCK_FREQUENCY, settings.getClockFreq());

// Set SPI configuration structure for 16-bit transfers
memset(&config16, 0, sizeof(struct spi_config));
config16.operation = mode | SPI_WORD_SET(16);
config16.frequency = max(SPI_MIN_CLOCK_FEQUENCY, settings.getClockFreq());
config16.frequency = max(SPI_MIN_CLOCK_FREQUENCY, settings.getClockFreq());
}

void arduino::ZephyrSPI::endTransaction(void) {
Expand Down
4 changes: 2 additions & 2 deletions libraries/SPI/SPI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@

// TODO:
// This depends on the clock settings, can't be used for all boards.
#ifndef SPI_MIN_CLOCK_FEQUENCY
#define SPI_MIN_CLOCK_FEQUENCY 1000000
#ifndef SPI_MIN_CLOCK_FREQUENCY
#define SPI_MIN_CLOCK_FREQUENCY 1000000
#endif

/* Count the number of GPIOs for limit of number of interrupts */
Expand Down