Skip to content

Update uotghs_host.c #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update uotghs_host.c #66

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63b4e02
Update uotghs_host.c
martinzw Apr 22, 2019
7a44418
Update uotghs_host.c
martinzw Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/libsam/source/uotghs_host.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ void UHD_Pipe_Free(uint32_t ul_pipe)
uint32_t UHD_Pipe_Read(uint32_t ul_pipe, uint32_t ul_size, uint8_t* data)
{
uint8_t *ptr_ep_data = 0;
uint8_t nb_byte_received = 0;
uint16_t nb_byte_received = 0; //otherwise roll over when reading pipe >256 Bytes
Copy link
Contributor

@per1234 per1234 Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the comment on this line will be confusing when read without the context of the other information in this pull request. If the comment is to be there, I think it could be better worded.

Copy link
Author

@martinzw martinzw Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right.
Changed comment

uint32_t ul_nb_trans = 0;

// Get information to read data
Expand Down