Jira 870, Change sensortag_button.ino to use localName #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature added:
- Since the BLE library now support the Scan
Response Data processing, update the sketch
to look for the sensorTag localName instead
of its specific unit address.
Cod mods:
1. sensortag_button.ino:
- Replace MAC address comparison with localName
string comparison.
Contributor
Author
|
@russmcinnis , change the senortag_button.ino as per your suggestion. Did update the comment block to make sure the user is aware of the localName may vary. Please test it. |
russmcinnis
approved these changes
Mar 6, 2017
Contributor
russmcinnis
left a comment
russmcinnis
left a comment
There was a problem hiding this comment.
Tested sensortag_button.ino with this PR and it is now possible to run without any changes to the sketch for my model of sensor tag. This change is good.
Contributor
Author
|
@yashaswini-hanji , please merge the PR to main trunk and close out the ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature added:
Response Data processing, update the sketch
to look for the sensorTag localName instead
of its specific unit address.
Cod mods:
string comparison.