Jira 858, Can't trigger BLEConnected, BLEDisconnected events, git 445 #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR originates from one segment of #447 to address Jira 858 (git issue 445). @eriknyquist , Made the changes you requested in #447, please review. @russmcinnis @noelpaz , please re-test this item since there is code change involved since the last round. Thanks. |
eriknyquist
approved these changes
Feb 23, 2017
russmcinnis
approved these changes
Feb 28, 2017
Contributor
russmcinnis
left a comment
russmcinnis
left a comment
There was a problem hiding this comment.
system tests and unit tests passed. Connect and Disconnect events are logged in the serial console as expected.
Root casue:
- The callback regiter before the begin and the begin
reset the callback.
Code mods:
1. BLEPeripheral.cpp:
- Remove clearing of callback register array at begin(). The
array is cleared upon system initialization.
Contributor
Author
|
@yashaswini-hanji , please merge this PR to main trunk and close the Jira ticket |
Contributor
|
PR merged and Jira closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root casue:
reset the callback.
Code mods:
array is cleared upon system initialization.