Jira 804 BLE Characteristic initialization issue, git 366 #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidLeung
requested review from
bigdinotech,
eriknyquist,
noelpaz and
russmcinnis
Contributor
Author
|
@bigdinotech @eriknyquist , please review the code. @noelpaz @russmcinnis , please perform system testing. Please refer to the example presented by Sandeep in the github issue. @sgbihu , thank you for the resolution. |
eriknyquist
approved these changes
Feb 8, 2017
Contributor
Author
|
@noelpaz , @russmcinnis , awaiting your approval to merge and close this PR. |
Issue: - Created Characteristic failed to reflect the initialized value. Root cause: - During initialization, the length field was incorrectly skipped over.
Contributor
Author
|
@yashaswini-hanji , please merge this PR to main and close out the Jira 804 upon completion. |
Contributor
|
Changes merged to base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
value.
Root cause:
skipped over.