Jira 796, as Peripheral, initialization of local buffer incorrectly set the write flag, git 380 #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…first connect
1. Not set the flage when local device try to set the value.
2. Changed file
libraries/CurieBLE/src/internal/BLECharacteristicImp.cpp
SidLeung
changed the title
Contributor
|
In Peripheral mode, the initialization of the local buffer via setValue() incorrectly set the Write Flag. As a consequence, the Central detect a write operation without initiating one. @bigdinotech @eriknyquist , please review the code change. @noelpaz @russmcinnis , please perform system verification testing. |
eriknyquist
approved these changes
Feb 7, 2017
bigdinotech
approved these changes
Feb 7, 2017
Contributor
|
@russmcinnis completed the BAT test and we found no issues. I am now doing Elisyss analysis and reporting out soon. |
Contributor
|
@yashaswini-hanji , would you please merge this PR to the main trunk? |
Contributor
|
Changes merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onnect
libraries/CurieBLE/src/internal/BLECharacteristicImp.cpp