Jira #758, Add scan response support for central role, git 370 #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bigdinotech @eriknyquist , please review the code change. @noelpaz @russmcinnis , this feature has gone through unit testing. Please perform verification testing. |
eriknyquist
approved these changes
Jan 31, 2017
SidLeung
force-pushed
the
Jira758
branch
2 times, most recently
from
aeda2c1 to
75dc565
Compare
Contributor
Author
|
@russmcinnis @noelpaz , please check out the additional changes to the PR - the adv info of the Scan Respond data are returned to the user sketch. |
SidLeung
force-pushed
the
Jira758
branch
2 times, most recently
from
a1bb62b to
2e749d5
Compare
Contributor
Author
|
PR merging error corrected. Regenerated the JSON here, http://mkfs.ndg.intel.com/precommit/json/package_0.0.197_index.json |
Contributor
Author
|
@russmcinnis @noelpaz , please re-test this PR. Some changes were not merged into the last PR. Thanks. |
Contributor
Author
|
@russmcinnis , previous emerge had an error and is corrected. Please retry your testing. Thanks. |
SidLeung
force-pushed
the
Jira758
branch
2 times, most recently
from
c26a529 to
4b4240e
Compare
Feature added:
1. GIT#370 Add scan response support for central role
Arduino request that the BLE library, in Peripheral mode,
to support Scan Response Data request from a Central.
2. Arduino expects the reply similar to an Apple device.
They have provide a policy for the construction of the
Scan Response data message.
3. Jira 836 BLE Central scan does not enumerate peripherals that are
non connectable.
In Central mode, the BLE library should enumerate Peripheral
that are non-connectable (eg beacon).
Code mods:
BLEDevice.cpp:
1. Add the call to get Manufacturer Data info from a Peripheral.
Non-connectable device may only broadcast this info.
BLEDeviceManager.cpp:
1. Added setAdvertiseData() for the creation of the Scan Response Data message.
2. In advDataInit(), follows the policy (defined by Arduino) to add Adv data to
the Scan Response Data message using setAdvertiseData().
3. Delete the filter about non-connectable advertisement.
4. Added APIs, hasManufacturerData(), setManufacturerData(),
hasManufacturerData(), to gain access to adv info of
non-connectable Peripherals.
BLEDeviceManager.h:
BLEDevice.h:
Prototyping.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code modification is to enable the processing of the Scan Response data when the BLE stack is operating in the Central mode.