CurieBLE: Add support for "some" 16-bit + 128-bit UUID's and shortened name #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This issue is logged as Jira 792. It is under internal review, testing. Upon completion, will be merged to master and in the nightly JSON build. Will update here when the JSON has this change. |
Contributor
Author
|
The data structure for "some" and "all" EIR types are the same, it's more semantics. "All" means all the services the peripheral provides are advertised, "some" means only some of the services are advertised, when the connected to the peripheral can have more services than advertised. |
Contributor
|
PR #450 addresses this request. Will be in the next release. |
Contributor
Author
|
Closing this, as this PR was replicated in #450 which has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes resolve #371 and #372 for me.