Fix and simplify SensorTag button example #374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Assigning @russmcinnis to verify and test this. |
Contributor
|
This PR is under internal testing and review. Upon completion, it will be merged to master. |
Contributor
|
Test passed and no impact on other libraries. Run BAT and manual testing. Jira 861 @yashaswini-hanji Please merge and close JIRA |
Contributor
|
PR merged to base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these changes the example does not work with my TI SensorTag.
I've also simplified the example, since it just needs to deal with the
0xffe0service.