Improvements for CurieBLE library #279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trying to detect high frequencies.
Since Arduino/Genuino 101 uses USB native port, wait for the Serial port to open before executing the sketch to not lose serial data already sent to the Serial monitor Signed-off-by: Biagio Montaruli <biagio.hkr@gmail.com>
- Add CurieBLE Datatype - Add new methods : "end" and "setDeviceName" - Remove inexistent methods : "str", "data" and "length" - Add two new constants from BLEcommon.h file header : "BLE_MAX_ATTR_DATA_LEN" and "BLE_DEVICE_NAME_DEFAULT_PREFIX" Signed-off-by: Biagio Montaruli <biagio.hkr@gmail.com>
Signed-off-by: Biagio Montaruli <biagio.hkr@gmail.com>
Contributor
|
You've changed many files from other libraries here besides BLE. Please remove these files, and add one PR per library. |
Contributor
Author
|
Hi @eriknyquist,
Best regards. |
calvinatintel
force-pushed
the
master
branch
from
ce97bd7 to
aaaf3db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while(!Serial) ;in order to wait for the Serial port to connect since Arduino/Genuino 101 has native USB port;