Jira566 I2S DMA improvement: add two extra buffer on TX and RX side #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@linrjing looks good. But can you please combine it with the existing I2S library? |
Contributor
|
@linrjing please update commit message to accurately describe the changes |
Contributor
|
@eriknyquist How would you title/comment the change? I'm making a new PR with the |
Merged
Contributor
|
Replaced by PR #233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xieqi @sgbhu @SidLeung
Add two extra buffer on TX and RX side because of the padding zero. Code is still in investigation.