ATLEDGE-619: fix dtostrf #217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@SidLeung @bigdinotech ready for review |
Contributor
Contributor
|
@eriknyquist Looks good. @bigdinotech Please check it out. |
Use a different method for float->string conversion, and fix the width calculation so that extra spaces are only printed if the width parameter exceeds the output string length (ie. a mininum width, as specified by dtostrf reference from avr-libc).
Contributor
Author
|
@calvinatintel ready to merge. |
Contributor
|
cherry-picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different method for float->string conversion, and
fix the width calculation so that extra spaces are only
printed if the width parameter exceeds the output string
length (ie. a mininum width, as specified by dtostrf
reference from avr-libc).