Serial Monitor: improved "show timestamp" performance #7911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch dramatically reduce pressure on heap memory: - use a StringTokenizer instead of the very slow String.split(...) method to decode newlines. This avoid allocation/deallocation of big strings array and use of regexp. - pre allocate as many object as possible to avoid new allocation while streaming data. - the "timestamp" string is calculated only once per iteration. - use StringBuilder instead of inline temporary strings (that are, again, allocated and deallocated on each iteration)
This saves an access to the Document object (as well as a bunch temporary object allocations).
This saves another "append" call while streaming.
Contributor
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7911-BUILD-756-linux32.tar.xz ℹ️ The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested with an Arduino Due printing in a tight-loop on a medium-sized Desktop PC.
Before the patch:
After the patch:
@PaulStoffregen @MichalSy @mfalkvidd @feikname