Skip to content

Adding HttpClient #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Adding HttpClient #69

wants to merge 8 commits into from

Conversation

@amcewen
Copy link
Contributor

@amcewen amcewen commented Mar 30, 2012

Here's the HttpClient, updated as per discussions on the Developers list (including using completed() rather than eof().

kmpm and others added 8 commits December 13, 2011 09:06
Implementation of DHCP lease handling
93f8b0e 
Requires a periodic call to the new method Ethernet.maintain()
http://code.google.com/p/arduino/issues/detail?id=716
Update to the new IP if anything was received.
e121b98
@amcewen
Merge remote-tracking branch 'kmpm/issue-716'
5041415
@amcewen
Merge remote-tracking branch 'upstream/master'
d192a25 
Conflicts:
	libraries/Ethernet/Dhcp.cpp
	libraries/Ethernet/Ethernet.cpp
	libraries/Ethernet/Ethernet.h
@amcewen
Merge branch 'master' of https://github.com/arduino/Arduino
685b02e
@amcewen
Adding HttpClient to the set of libraries
98b804e
@amcewen
Added readUntil methods which deal with String types
9af8f00
@amcewen
Added ability to "attach" another Print object to another Print objec…
5d679ae 
…t in order to output what is sent/received with it (to aid in debugging things like network protocols - you attach Serial to the EthernetClient, for example, and it'll dump all the data sent/received to the serial port)
@ffissore ffissore added the New label Feb 27, 2014
@cmaglie cmaglie added feature request A request to make an enhancement (not a bug fix) Library: Other Arduino libraries that don't have their own label labels Apr 8, 2015
@cmaglie
Copy link
Member

cmaglie commented Jul 14, 2015

@amcewen
I see that the HttpClient library is now in the library manager, can we close this PR?

@cmaglie cmaglie added the Waiting for feedback More information must be provided before we can proceed label Jul 14, 2015
@cmaglie cmaglie added this to the Release 1.6.6 milestone Jul 14, 2015
@amcewen
Copy link
Contributor Author

amcewen commented Jul 17, 2015

@cmaglie yes, that makes sense (unless you'd like to take it into the core, in which case I could work up a new version...)

@amcewen amcewen closed this Jul 17, 2015
@cmaglie
Copy link
Member

cmaglie commented Jul 17, 2015

Thanks!

unless you'd like to take it into the core, in which case I could work up a new version...

Having it into the core is a maintenance burden and adds delays in the update process.
Believe me, it's 10 times better to have it maintained independently from the upstream author, especially if he's active like you :-), especially now that the library manager makes it very simple to install/upgrade.

@amcewen
Copy link
Contributor Author

amcewen commented Jul 17, 2015

Hehe, I'm not sure I'm "active", more sporadic I think ;-)

tbowmo pushed a commit to tbowmo/Arduino that referenced this pull request Jul 14, 2016
@henrikekblad
Merge pull request arduino#69 from fallberg/development
fee149a 
ATSHA204 personalization sketch updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cmaglie cmaglie

Labels

feature request A request to make an enhancement (not a bug fix) Library: Other Arduino libraries that don't have their own label Waiting for feedback More information must be provided before we can proceed

Projects

None yet

Milestone

Release 1.6.6

Development

Successfully merging this pull request may close these issues.

4 participants

@amcewen @cmaglie @matthijskooijman @ffissore